-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix incorrect new feature description in Kilted #5677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice-1235 <[email protected]>
fujitatomoya
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mini-1235 thanks for creating PR.
lgtm with @christophebedard 's comment.
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: mini-1235 <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: mini-1235 <[email protected]>
christophebedard
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2025
Signed-off-by: Maurice-1235 <[email protected]> (cherry picked from commit 898cd4c)
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2025
Signed-off-by: Maurice-1235 <[email protected]> (cherry picked from commit 898cd4c)
This was referenced May 27, 2025
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2025
Signed-off-by: Maurice-1235 <[email protected]> (cherry picked from commit 898cd4c)
christophebedard
pushed a commit
that referenced
this pull request
May 27, 2025
(cherry picked from commit 898cd4c) Signed-off-by: Maurice-1235 <[email protected]> Co-authored-by: mini-1235 <[email protected]>
christophebedard
pushed a commit
that referenced
this pull request
May 27, 2025
(cherry picked from commit 898cd4c) Signed-off-by: Maurice-1235 <[email protected]> Co-authored-by: mini-1235 <[email protected]>
christophebedard
pushed a commit
that referenced
this pull request
May 27, 2025
(cherry picked from commit 898cd4c) Signed-off-by: Maurice-1235 <[email protected]> Co-authored-by: mini-1235 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5674
Did you use Generative AI?
No
Additional Information