Skip to content

Fix incorrect new feature description in Kilted #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

mini-1235
Copy link
Contributor

Description

Fixes #5674

Did you use Generative AI?

No

Additional Information

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mini-1235 thanks for creating PR.

lgtm with @christophebedard 's comment.

@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label May 27, 2025
Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@christophebedard christophebedard merged commit 898cd4c into ros2:rolling May 27, 2025
5 checks passed
mergify bot pushed a commit that referenced this pull request May 27, 2025
Signed-off-by: Maurice-1235 <[email protected]>
(cherry picked from commit 898cd4c)
mergify bot pushed a commit that referenced this pull request May 27, 2025
Signed-off-by: Maurice-1235 <[email protected]>
(cherry picked from commit 898cd4c)
mergify bot pushed a commit that referenced this pull request May 27, 2025
Signed-off-by: Maurice-1235 <[email protected]>
(cherry picked from commit 898cd4c)
christophebedard pushed a commit that referenced this pull request May 27, 2025
(cherry picked from commit 898cd4c)

Signed-off-by: Maurice-1235 <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
christophebedard pushed a commit that referenced this pull request May 27, 2025
(cherry picked from commit 898cd4c)

Signed-off-by: Maurice-1235 <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
christophebedard pushed a commit that referenced this pull request May 27, 2025
(cherry picked from commit 898cd4c)

Signed-off-by: Maurice-1235 <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
@mini-1235 mini-1235 deleted the fix-wrong-desc branch May 27, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect new feature mentioned in Kilted
3 participants