Skip to content

add ROS_APT_SOURCE_VERSION env variable to fetch release version. #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

fujitatomoya
Copy link
Collaborator

Description

Use ROS_APT_SOURCE_VERSION environmental variable to install ros2-apt-source.deb.

Fixes # (issue)

Follow up of #5675

Did you use Generative AI?

No

Additional Information

N.A

@fujitatomoya
Copy link
Collaborator Author

@fujitatomoya
Copy link
Collaborator Author

@claraberendsen btw, we need to apply the same change to rolling, jazzy and humble documentation as well?

Copy link

github-actions bot commented May 27, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/15285217819/artifacts/3207571347.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5676/index.html in your favorite browser

@claraberendsen
Copy link
Contributor

claraberendsen commented May 27, 2025

@claraberendsen btw, we need to apply the same change to rolling, jazzy and humble documentation as well?

Yes, I am in the process of creating the PRs for those ones.

@peci1
Copy link
Contributor

peci1 commented May 27, 2025

Hmm, I'd still very much prefer the version-less .debs or links to them. This seems a bit cumbersome (though working).

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Tully Foote <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

hmm, i do not mind having the single liner at all. usually user does not really need to know the version at all, just following the guide to install ros2-apt-source package. and i think having the capability that user technically choose and know the version if necessary (the issue report or debug) would be good for rolling update maintenance.

Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's on extra line, but I think that sticking with the official release infrastructure and having fully versioned content from the trusted source is preferred.

This in particular will make sure that the version numbers are visible in any logs and people know what they're getting and keeping.

If we were self hosting we could setup an url rewrite/redirect. But on GitHub this is a good compromise. It won't change release to release, and artifacts are fully versioned supporting introspection and rollback.

@claraberendsen
Copy link
Contributor

I'll go ahead and merge this and start porting it to the other distros docs

@claraberendsen claraberendsen merged commit 2c06f38 into kilted May 27, 2025
5 checks passed
@claraberendsen claraberendsen deleted the fujitatomoya/kilted/use-ROS_APT_SOURCE_VERSION branch May 27, 2025 21:54
@claraberendsen
Copy link
Contributor

Thanks @fujitatomoya for setting this up!

@peci1
Copy link
Contributor

peci1 commented May 27, 2025

Uh-oh: https://api.github.com/repos/ros-infrastructure/ros-apt-source/releases/latest

{
  "message":"API rate limit exceeded for 147.XX.XXX.XXX. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
  "documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"
}

Probably accessing this from large campuses can have its downsides...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants