Skip to content

Fix node name and port in diagnostic_remote_logging README #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

christophfroehlich
Copy link
Contributor

There are some issues in the README, it took me some time to set everything up (in the end it worked fine!)

  • the node name is different, resulting in the parameter yaml not being used
  • yaml syntax forbids keys without values
  • the telegraf input listener needs a different port if the influxdb still uses the default 8086

@mergify mergify bot added the ros2 PR tackling a ROS2 branch label Jul 1, 2025
@ct2034 ct2034 added the bug This is a bug in the code (and not a new feature) label Jul 7, 2025
@ct2034
Copy link
Collaborator

ct2034 commented Jul 7, 2025

@dwffls can you please look into this

@dwffls
Copy link
Contributor

dwffls commented Jul 10, 2025

All these changes are indeed correct. Made some mistakes with the creation of the README.
So feel free to merge these!

@christophfroehlich Thanks for catching these, and happy to hear that the rest works fine for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug in the code (and not a new feature) ros2 PR tackling a ROS2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants