Feat: angular_bounds_filter_in_place dynamic parameters and new enabled parameter #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_in_place-dynamic-parameters-and-new-enabled-parameter feat: angular_bounds_filter_in_place dynamic parameters and new enabl…
|
Instead of making this filter more complicated by adding an on/off toggle, could you use a mux node to toggle between the scan and the filtered scan when the configuration changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
In our application, we need to toggle angular bounds filters at runtime to handle physical configuration changes in our mobile platform. The current implementation does not provide this feature.
Proposed changes
A new enabled parameter is added, when toggled to false the scan will simply copy the input_scan into the output_scan.
The reconfigureCB() method is overridden to handle dynamic reconfiguration of the filter's parameters.