-
Notifications
You must be signed in to change notification settings - Fork 368
Deactivate the whole controller chain if one of the update results in ERROR #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saikishor
wants to merge
14
commits into
ros-controls:master
Choose a base branch
from
pal-robotics-forks:deactivate/full/controller_chain/update_failure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Deactivate the whole controller chain if one of the update results in ERROR #2681
saikishor
wants to merge
14
commits into
ros-controls:master
from
pal-robotics-forks:deactivate/full/controller_chain/update_failure
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2681 +/- ##
==========================================
+ Coverage 89.33% 89.49% +0.15%
==========================================
Files 151 151
Lines 17138 17468 +330
Branches 1435 1449 +14
==========================================
+ Hits 15311 15633 +322
- Misses 1245 1249 +4
- Partials 582 586 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
199e749
to
e1db65b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-jazzy
Triggers PR backport to ROS 2 jazzy.
backport-kilted
Triggers PR backport to ROS 2 kilted.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a way to deactivate the whole controller chain when one of the controllers in the chain is deactivated as a result of it returning
ERROR
in the update cycle.For instance, for the following example, if the controller B fails, then it is deactivated automatically, but all the other controllers are left dangling, and they are left to track an invalid reference, this might lead to a catastrophic behaviour, this is especially true when you are tracking a
velocity
,force
, ortorque
references. The idea is to bring down the whole chain along with it.