Fix #14: allow for UID/GID specification via PUID/PGID env variables #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I made it so you can specify PUID/PGID when starting this container, fixing #14.
TLDR; Add the openttd user as normal, but run a new entrypoint as root which changes the uid/gid on "openttd" to the specified ones and then drops privileges to that user and runs the original entrypoint
I took some inspiration from how LinuxServers do it [1] , and also this Dockerfile/entrypoint where gosu was used https://github.com/sudo-bmitch/jenkins-docker/tree/main
Using gosu seems to be common practice [3]
[1] https://github.com/linuxserver/docker-baseimage-ubuntu/blob/focal/root/etc/s6-overlay/s6-rc.d/init-adduser/run
[2] (https://github.com/tianon/gosu?tab=readme-ov-file#gosu
[3] https://denibertovic.com/posts/handling-permissions-with-docker-volumes/