Skip to content

Fix #510 #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #510 #512

wants to merge 1 commit into from

Conversation

mem48
Copy link
Collaborator

@mem48 mem48 commented Jan 12, 2023

Fix for bug identified in #510 problem occurs when input lines have repeated coordinates for some reason this is acceptable in long linestrings st_is_valid == TRUE but not short linestrings st_is_valid == FALSE

@mem48
Fix #510
a5258fa 
Fix for bug identified in #510 problem occurs when input lines have repeated coordinates for some reason this is acceptable in long linestrings st_is_valid == TRUE but not short linestrings st_is_valid == FALSE
Robinlovelace
Robinlovelace requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should there be a message if there are invalid geometries explaining how many linestrings and the percentage of linestrings removed? I think so. Marking as a requested change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Robinlovelace Robinlovelace Robinlovelace requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mem48 @Robinlovelace