only export methods + complete unless internal = true #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why? - makes sense to not return actions that shouldn't be used anyways - need special handling of `complete` in `feathers-action-react`, feels better if it's special already (as in the only exported action that isn't a method call), maybe
ahdinosaur
added a commit
to root-systems/feathers-action-react
that referenced
this pull request
May 15, 2017
fixes cancellation relevant: root-systems/feathers-action#18
This was referenced May 15, 2017
ahdinosaur
added a commit
to root-systems/feathers-action-react
that referenced
this pull request
Jul 26, 2017
fixes cancellation relevant: root-systems/feathers-action#18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
completeinfeathers-action-react, feels better if it's special already (as in the only exported action that isn't a method call), maybe