[math/RF] Reduce test failures when ROOT is built without clad or gsl #20027
+35
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clad is off, the tests were failing. With the standard backend, they run fine, though.
guitargeek
requested changes
Oct 3, 2025
Test Results 21 files 21 suites 3d 20h 13m 48s ⏱️ Results for commit b889d63. ♻️ This comment has been updated with latest results. |
Also fix a warning that protects from a Gaussian with sigma=0. Co-authored-by: Jonas Rembser <[email protected]>
When MathMore cannot be loaded, the tutorial exampleFunction.py used to crash. Here, an exception is added thrown in the constructor, which can be caught in the Python tutorial.
guitargeek
approved these changes
Oct 3, 2025
vgvassilev
reviewed
Oct 7, 2025
|
|
||
| // Fit 1 - RooMultiPdf fit | ||
|
|
||
| std::unique_ptr<RooAbsReal> nll{multipdf.createNLL(*data, EvalBackend("codegen"))}; |
There was a problem hiding this comment.
Can we do it the opposite way. We have the ifdef in the EvalBackend("codegen") where we check if clad is not on, we warn and switch to EvalBackend::defaultValue()?
There was a problem hiding this comment.
I guess that possible. @guitargeek, OK with you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with ROOT where some features were off, I encountered test failures. These commits reduce some of those, namely: