[RF] Make RooFit more independent of locale setting #19733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
issue-17797
branch
2 times, most recently
from
c4f3f2b to
7195dcc
Compare
Test Results 21 files 21 suites 3d 13h 7m 43s ⏱️ For more details on these failures, see this check. Results for commit d90d12c. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
issue-17797
branch
from
7195dcc to
3408092
Compare
When constructing a RooProdPdf, the list of pdfs has to be passed in a collection. I noticed this problem now by making the conversion of strings to doubles a bit stricter and throw on failure. The test only passed by chance before.
Refactor to make the code simpler and skip the debug printouts. Creating RooRealVars is pretty straight forward, so I don't think it's worth to do logging here. One has to pay the price for string manipulations and flooding the debug log that will not help users to understand problems.
The conversions from strings to double should be locale-independent, otherwise one might silently get wrong results when the locale is set to e.g. german, where they use a comma instead of a period for floating point numbers. Closes root-project#17797.
This ensures that RooFit printouts will be independent of the locale
setting.
Here is my little script to test this:
```Python
import locale
def check_numeric_locale():
locale.setlocale(locale.LC_ALL, "")
# Get the active numeric locale
current = locale.setlocale(locale.LC_NUMERIC)
print(f"Active LC_NUMERIC: {current}")
# Format a floating point number according to this locale
number = 12345.67
formatted = locale.format_string("%.2f", number, grouping=True)
print(f"Formatted number: {formatted}")
# Show what decimal point is being used
conv = locale.localeconv()
print(f"Decimal point: {conv['decimal_point']}")
print(f"Thousands separator: {conv['thousands_sep']}")
if __name__ == "__main__":
check_numeric_locale()
import ROOT
print(ROOT.std.stod("3.33"))
x = ROOT.RooRealVar("x", "x", 3.12, -10., 10.)
x.setError(1.23)
print(x.format(4, ""))
ROOT.RooRealVar.printScientific(True)
x.writeToStream(ROOT.std.cout, False)
x.writeToStream(ROOT.std.cout, True)
```
The `std::to_string` function is not locale-independent, so we should better not use is for floating point numbers.
guitargeek
force-pushed
the
issue-17797
branch
from
3408092 to
d90d12c
Compare
guitargeek
force-pushed
the
issue-17797
branch
from
a27d73e to
d90d12c
Compare
|
Thanks for the review! I accidentally pushed an unrelated commit to this branch, but I removed that one again to get back to the state of where the PR was reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17797 by making string conversion to double and printing of doubles to strings independent of locale settings.