-
-
Notifications
You must be signed in to change notification settings - Fork 189
Default Plugin Versions to AssemblyVersion when not provided #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KillStr3aK
wants to merge
17
commits into
roflmuffin:main
Choose a base branch
from
KillStr3aK:future/340
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
748c9cd
change `ModuleVersion` to `virtual` and added a backing field for ver…
KillStr3aK 0b2d9a1
feat: priority order for plugin version
KillStr3aK 288e5df
Merge branch 'main' into future/340
KillStr3aK 5b6fdc2
Merge branch 'main' into future/340
KillStr3aK 900a043
Merge branch 'main' into future/340
KillStr3aK 3f1b55c
Merge branch 'main' into future/340
KillStr3aK e4dc875
Merge branch 'main' into future/340
KillStr3aK 7e7405e
Merge branch 'main' into future/340
KillStr3aK 2526d4c
Merge branch 'main' into future/340
KillStr3aK 6c1c02d
Merge branch 'main' into future/340
KillStr3aK 28ba946
Merge branch 'main' into future/340
KillStr3aK 29b7898
Merge branch 'main' into future/340
KillStr3aK 7947491
Merge branch 'main' into future/340
KillStr3aK 9384af1
Merge branch 'main' into future/340
KillStr3aK 8d04113
Merge branch 'main' into future/340
KillStr3aK 616300a
Merge branch 'main' into future/340
KillStr3aK e507fc0
Merge branch 'main' into future/340
KillStr3aK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,6 +204,26 @@ public void Load(bool hotReload = false) | |
|
||
if (Plugin == null) throw new Exception("Unable to create plugin instance"); | ||
|
||
/* Version Priority order: | ||
* ModuleVersion override | ||
* Assembly.GetName().Version | ||
* "<unknown>" | ||
*/ | ||
if (Plugin is BasePlugin basePlugin) | ||
{ | ||
// if no override we look for assembly version | ||
if (basePlugin._version == "<unknown>") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe |
||
{ | ||
Version? assemblyVersion = defaultAssembly.GetName().Version; | ||
|
||
// if its set, we use that, otherwise it remains "<unknown>" | ||
if (assemblyVersion != null) | ||
{ | ||
basePlugin._version = assemblyVersion.ToString(); | ||
} | ||
} | ||
} | ||
|
||
State = PluginState.Loading; | ||
|
||
Plugin.ModulePath = _path; | ||
|
@@ -241,4 +261,4 @@ public void Unload(bool hotReload = false) | |
_logger.LogInformation("Finished unloading plugin {Name}", cachedName); | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried loading a plugin compiled with this API against an older version of CS#? Does it complain about the virtual/abstract change when its being invoked or does it generate the same IL code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I recall correctly I did not, but I'll check today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the other way around would also be good, so old plugin against new CS#.