chore: rm old alertThreshold and trigger-per-lead-time code AB#34442

[jannisvisser]

DO NOT MERGE until the typhoon pipeline is tested for all scenarios. AB#36257

Describe your changes

See AB#34442

Checklist before requesting a review

• I have performed a self-review of my code
• I have added tests wherever relevant
• I have made sure that all automated checks pass before requesting a review

[jannisvisser]

@gulfaraz I thought what Aki found and still needs to test was unrelated to the API changes (and would therefore not block merging this). But apparently not?

[gulfaraz]

@jannisvisser In yesterday's standup, I informed the team that I will review and merge this PR. @aklilu requested that we block this change until he tests the typhoon pipeline in event scenarios. He mentioned that the typhoon pipeline was tested on only the no-event scenario, so his confidence in this change is low.

I created AB#36257 and assigned it to @aklilu to track this effort.

I thought what Aki found

I assume you're talking about the bug @aklilu found in the typhoon pipeline. AFAIK, his request to block this PR is unrelated to that bug.

[jannisvisser]

@gulfaraz apart from the do-not-merge-warning, was this reviewed by you already?

[gulfaraz]

@jannisvisser yes