Skip to content

Add possibility to configure Run with entire Downloader, ItemPipeline and Processor instances #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add possibility to configure Run with entire Downloader, ItemPipeline and Processor instances #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/Core/Engine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,24 @@ private function scheduleRequest(Request $request): void
private function configure(Run $run): void
{
$this->scheduler->setDelay($run->requestDelay);
$this->itemPipeline->setProcessors(...$run->itemProcessors);
$this->downloader->withMiddleware(...$run->downloaderMiddleware);
$this->responseProcessor->withMiddleware(...$run->responseMiddleware);

if (null !== $run->itemPipeline) {
$this->itemPipeline = $run->itemPipeline;
} else {
$this->itemPipeline->setProcessors(...$run->itemProcessors);
}

if (null !== $run->downloader) {
$this->downloader = $run->downloader;
} else {
$this->downloader->withMiddleware(...$run->downloaderMiddleware);
}

if (null !== $run->responseProcessor) {
$this->responseProcessor = $run->responseProcessor;
} else {
$this->responseProcessor->withMiddleware(...$run->responseMiddleware);
}

foreach ($run->extensions as $extension) {
$this->eventDispatcher->addSubscriber($extension);
Expand Down
9 changes: 9 additions & 0 deletions src/Core/Run.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@

namespace RoachPHP\Core;

use RoachPHP\Downloader\Downloader;
use RoachPHP\Downloader\DownloaderMiddlewareInterface;
use RoachPHP\Extensions\ExtensionInterface;
use RoachPHP\Http\Request;
use RoachPHP\ItemPipeline\ItemPipelineInterface;
use RoachPHP\ItemPipeline\Processors\ItemProcessorInterface;
use RoachPHP\Spider\Processor;
use RoachPHP\Spider\SpiderMiddlewareInterface;

/**
Expand All @@ -30,6 +33,9 @@ final class Run
* @param ItemProcessorInterface[] $itemProcessors
* @param SpiderMiddlewareInterface[] $responseMiddleware
* @param ExtensionInterface[] $extensions
* @param null|Downloader $downloader
* @param null|ItemPipelineInterface $itemPipeline
* @param null|Processor $responseProcessor
*/
public function __construct(
public array $startRequests,
Expand All @@ -39,6 +45,9 @@ public function __construct(
public array $extensions = [],
public int $concurrency = 25,
public int $requestDelay = 0,
public ?Downloader $downloader = null,
public ?ItemPipelineInterface $itemPipeline = null,
public ?Processor $responseProcessor = null,
) {
}
}