Move Lazy resolution into Dataloader #5314
Open
+223
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a moonshot but I want to see if the runtime code can be simplified by rebuilding
lazy_resolve
on top ofGraphQL::Dataloader
. Some hard requirements:The reason I want to do this is because I want more flexibility in how GraphQL execution is started and stopped, so that I could reasonably support Ruby's lazy enumerators (#4907) and partial query execution (#5183).
My todos:
legacy_sync_lazy(true)
can be replaced with Dataloader...