Visibility: hide unreferenced arg types #5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rmosolgo merged 3 commits into master from hide-unreferenced-arg-types

Apr 7, 2025

Owner

rmosolgo commented Mar 21, 2025 •

edited

Loading

Part of #5265

This boiled down to two changes:

Extend argument visibility check to include a check to its owner
When checking a type's visibility, add a referenced? check which also makes a check of the reference's visibility


          Add failing spec

1ed9572

rmosolgo mentioned this pull request

Visibility leaves dangling types #5265

Open


          Stricter check on reference visibility

68f1a51

rmosolgo added this to the 2.5.2 milestone


          Use the passed-in owner for Argument checks

rmosolgo merged commit 96aeb2b into master

15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet