Skip to content

Add support for 20 new languages #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mark-kadence
Copy link

@mark-kadence mark-kadence commented May 1, 2025

Add Support for 20 New Languages

This PR adds support for 20 new languages:

  • Bulgarian (bg)
  • Czech (cs)
  • Welsh (cy)
  • Estonian (et)
  • Filipino (fil)
  • Irish (ga)
  • Croatian (hr)
  • Hungarian (hu)
  • Indonesian (id)
  • Lithuanian (lt)
  • Latvian (lv)
  • Norwegian (nb)
  • Romanian (ro)
  • Slovak (sk)
  • Slovenian (sl)
  • Serbian (sr)
  • Swahili (sw)
  • Turkish (tr)
  • Ukrainian (uk)
  • Vietnamese (vi)
  • Yoruba (yo)

Changes

  • Added translation files for each new language in src/i18n/
  • Each language file follows the established translation structure
  • Maintains consistency with existing translation patterns

Testing

  • Translations can be verified using the existing translation review tool:
    ./bin/review_translations.php --locale <locale>

@rlanvin
Copy link
Owner

rlanvin commented May 18, 2025

Thanks but to be honest I don't know what to do with this MR. Usually I get MR from native speakers to add their own language, which gives me a certain degree of confidence that the translation works in context. The translation system in the lib is rather primitive and sometimes require some creative word-smithing in some languages. But this looks AI-generated and the list is very random, so how am I supposed to review that?

I have also some questions...

  • Why those 20 languages in particular?
  • Why Filipino specifically instead of Tagalog (tl)? Is there anything specific to Filipino in the translation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants