Include TS declarations from generated sources in node_modules_package
#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand this well. Claude Code stumbled upon it as a fix for the regression we had after jumping from rules_js of August 2022 to March 2025 in our main repo. The issue is we have a ts_library containing .js, .js.map, and .d.ts files generated from X12 fixtures. Updating our pin on rules_js caused those .d.ts files to stop getting included in our node_modules_package target for VSCode type hints. (Other ts_library and js_import_ts targets were fine).
nevadaperry
force-pushed
the
Nevada/include-ts-declarations-in-ts-library-jsinfo
branch
from
680691f to
7664a3c
Compare
This avoids breaking several rules that expect JsInfo not to include type declarations. Seems like "transitive files" are just the files going in the package.
nevadaperry
force-pushed
the
Nevada/include-ts-declarations-in-ts-library-jsinfo
branch
from
7664a3c to
125f77a
Compare
nevadaperry
changed the title
JsInfonode_modules_package
nathanmoon
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our main repo, we have a
ts_librarytarget that includes.js,.js.map, and.d.tsfiles generated from X12 fixtures. When we updated from using rules_javascript of August 2022 to March 2025, those.d.tsfiles stopped getting included in ournode_modules_packagetarget that locally installs VSCode type hints. (Otherts_libraryandjs_import_tstargets were fine).This restores desired behavior of including type declarations from generated sources in
node_modules_packageoutput.