Skip to content

Add //nodejs:audit target; update vulnerabilities #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add //nodejs:audit target; update vulnerabilities #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6042627
Add `//nodejs:audit` target; update vulnerabilities
nevadaperry May 20, 2025
1ae85ce
Fix lint
nevadaperry May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ load("//commonjs:rules.bzl", "cjs_root")
load("//javascript:rules.bzl", "js_library")

exports_files(
["yarn.lock"],
[
"package.json",
"yarn.lock",
],
visibility = ["//visibility:public"], # tests
)

Expand Down
14 changes: 14 additions & 0 deletions nodejs/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("//npm:rules.bzl", "yarn_audit_test")

exports_files(
glob(["**/*.bzl"]),
Expand Down Expand Up @@ -54,3 +55,16 @@ test_suite(
tests = ["//nodejs/test"],
visibility = ["//:__subpackages__"],
)

yarn_audit_test(
name = "audit",
data = [
"//:package.json",
"//:yarn.lock",
],
tags = [
"external",
"no-sandbox",
"supports-graceful-termination",
],
)
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@
"npm-registry-fetch": "~14.0.2",
"prettier": "^3.4.2",
"prettier-plugin-organize-imports": "^3",
"protobufjs": "~6.11.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the upgrade steps to test this out? Can we test this version in a branch of rivet before we merge into main?

Copy link
Contributor Author

@nevadaperry nevadaperry May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can stick an unmerged rules_js commit SHA in WORKSPACE.bazel and put it on staging.

Edit: Per discussion with Nathan, this is low priority. We may replace Bazel before prioritizing this.

"protobufjs": "~6.11.4",
"reflect-metadata": "0.1.13",
"rollup": "^2.78.0",
"rollup": "^2.79.2",
"rxjs": "~7.4.0",
"tar-stream": "~2.2.0",
"ts-proto": "~1.83.0",
"ts-proto": "~1.148.2",
"tslib": "~2.0.0",
"typescript": "~5.0.0",
"zone.js": "~0.11.4"
Expand Down
123 changes: 66 additions & 57 deletions tools/npm/npm.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4759,7 +4759,7 @@ PACKAGES = {
"id": "@xml-tools/[email protected]",
},
{
"id": "prettier@3.1.1",
"id": "prettier@3.4.2",
},
],
"extra_deps": {
Expand Down Expand Up @@ -4888,7 +4888,7 @@ PACKAGES = {
"id": "[email protected]",
},
{
"id": "[email protected].1",
"id": "[email protected].2",
},
],
"extra_deps": {
Expand Down Expand Up @@ -4918,7 +4918,7 @@ PACKAGES = {
"id": "[email protected]",
},
{
"id": "[email protected].1",
"id": "[email protected].2",
},
],
"extra_deps": {
Expand All @@ -4939,7 +4939,7 @@ PACKAGES = {
"id": "[email protected]",
},
{
"id": "[email protected].1",
"id": "[email protected].2",
},
],
"extra_deps": {
Expand All @@ -4960,7 +4960,7 @@ PACKAGES = {
"id": "[email protected]",
},
{
"id": "[email protected].1",
"id": "[email protected].2",
},
],
"extra_deps": {
Expand Down Expand Up @@ -5392,15 +5392,6 @@ PACKAGES = {
"name": "@types/object-hash",
"url": "https://registry.npmjs.org/@types/object-hash/-/object-hash-1.3.4.tgz",
},
"@types/[email protected]": {
"deps": [
],
"extra_deps": {
},
"integrity": "sha512-5qOlnZscTn4xxM5MeGXAMOsIOIKIbh9e85zJWfBRVPlRMEVawzoPhINYbRGkBZCI8LxvBe7tJCdWiarA99OZfQ==",
"name": "@types/prettier",
"url": "https://registry.npmjs.org/@types/prettier/-/prettier-1.19.1.tgz",
},
"@types/[email protected]": {
"deps": [
],
Expand Down Expand Up @@ -9751,6 +9742,15 @@ PACKAGES = {
"name": "caniuse-lite",
"url": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001482.tgz",
},
"[email protected]": {
"deps": [
],
"extra_deps": {
},
"integrity": "sha512-zlOQ80VrQ2Ue+ymH5OuM/DlDq64mEm+B9UTdHULv5osUMD6HalNTblf2b1u/m6QecjsnOkBpqVZ+XPwIVsy7Ng==",
"name": "case-anything",
"url": "https://registry.npmjs.org/case-anything/-/case-anything-2.1.13.tgz",
},
"[email protected]": {
"deps": [
{
Expand Down Expand Up @@ -10357,6 +10357,15 @@ PACKAGES = {
"name": "depd",
"url": "https://registry.npmjs.org/depd/-/depd-1.1.2.tgz",
},
"[email protected]": {
"deps": [
],
"extra_deps": {
},
"integrity": "sha512-pGjwhsmsp4kL2RTz08wcOlGN83otlqHeD/Z5T8GXZB+/YcpQ/dgo+lbU8ZsGxV0HIvqqxo9l7mqYwyYMD9bKDg==",
"name": "detect-libc",
"url": "https://registry.npmjs.org/detect-libc/-/detect-libc-1.0.3.tgz",
},
"[email protected]": {
"deps": [
],
Expand Down Expand Up @@ -10540,6 +10549,18 @@ PACKAGES = {
"name": "dot-case",
"url": "https://registry.npmjs.org/dot-case/-/dot-case-3.0.4.tgz",
},
"[email protected]": {
"deps": [
{
"id": "[email protected]",
},
],
"extra_deps": {
},
"integrity": "sha512-iVKnUtYfGrYcW1ZAlfR/F59cUVL8QIhWoBJoSjkkdua/dkWIgjZfiLMeTjiB06X0ZLkQ0M2C1VbUj/CxkIf1zg==",
"name": "dprint-node",
"url": "https://registry.npmjs.org/dprint-node/-/dprint-node-1.0.8.tgz",
},
"[email protected]": {
"deps": [
],
Expand Down Expand Up @@ -15317,7 +15338,7 @@ PACKAGES = {
"[email protected]": {
"deps": [
{
"id": "prettier@3.1.1",
"id": "prettier@3.4.2",
},
{
"id": "[email protected]",
Expand All @@ -15329,23 +15350,14 @@ PACKAGES = {
"name": "prettier-plugin-organize-imports",
"url": "https://registry.npmjs.org/prettier-plugin-organize-imports/-/prettier-plugin-organize-imports-3.2.4.tgz",
},
"[email protected]": {
"deps": [
],
"extra_deps": {
},
"integrity": "sha512-vBZcPRUR5MZJwoyi3ZoyQlc1rXeEck8KgeC9AwwOn+exuxLxq5toTRDTSaVrXHxelDMHy9zlicw8u66yxoSUFg==",
"name": "prettier",
"url": "https://registry.npmjs.org/prettier/-/prettier-2.5.1.tgz",
},
"[email protected]": {
"[email protected]": {
"deps": [
],
"extra_deps": {
},
"integrity": "sha512-22UbSzg8luF4UuZtzgiUOfcGM8s4tjBv6dJRT7j275NXsy2jb4aJa4NNveul5x4eqlF1wuhuR2RElK71RvmVaw==",
"integrity": "sha512-e9MewbtFo+Fevyuxn/4rrcDAaq0IYxPGLvObpQjiZBMAzB9IGmzlnG9RZy3FFas+eBMu2vA0CszMeduow5dIuQ==",
"name": "prettier",
"url": "https://registry.npmjs.org/prettier/-/prettier-3.1.1.tgz",
"url": "https://registry.npmjs.org/prettier/-/prettier-3.4.2.tgz",
},
"[email protected]": {
"deps": [
Expand Down Expand Up @@ -15506,7 +15518,7 @@ PACKAGES = {
"name": "property-expr",
"url": "https://registry.npmjs.org/property-expr/-/property-expr-2.0.5.tgz",
},
"[email protected].2": {
"[email protected].4": {
"deps": [
{
"id": "@protobufjs/[email protected]",
Expand Down Expand Up @@ -15550,9 +15562,9 @@ PACKAGES = {
],
"extra_deps": {
},
"integrity": "sha512-4BQJoPooKJl2G9j3XftkIXjoC9C0Av2NOrWmbLWT1vH32GcSUHjM0Arra6UfTsVyfMAuFzaLucXn1sadxJydAw==",
"integrity": "sha512-5kQWPaJHi1WoCpjTGszzQ32PG2F4+wRY6BmAT4Vfw56Q2FZ4YZzK20xUYQH4YkfehY1e6QSICrJquM6xXZNcrw==",
"name": "protobufjs",
"url": "https://registry.npmjs.org/protobufjs/-/protobufjs-6.11.2.tgz",
"url": "https://registry.npmjs.org/protobufjs/-/protobufjs-6.11.4.tgz",
},
"[email protected]": {
"deps": [
Expand Down Expand Up @@ -15992,17 +16004,17 @@ PACKAGES = {
"name": "rimraf",
"url": "https://registry.npmjs.org/rimraf/-/rimraf-3.0.2.tgz",
},
"[email protected].1": {
"[email protected].2": {
"deps": [
{
"id": "[email protected]",
},
],
"extra_deps": {
},
"integrity": "sha512-uKxbd0IhMZOhjAiD5oAFp7BqvkA4Dv47qpOCtaNvng4HBwdbWtdOh8f5nZNuk2rp51PMGk3bzfWu5oayNEuYnw==",
"integrity": "sha512-fS6iqSPZDs3dr/y7Od6y5nha8dW1YnbgtsyotCVvoFGKbERG++CVRFv1meyGDE1SNItQA8BrnCw7ScdAhRJ3XQ==",
"name": "rollup",
"url": "https://registry.npmjs.org/rollup/-/rollup-2.79.1.tgz",
"url": "https://registry.npmjs.org/rollup/-/rollup-2.79.2.tgz",
},
"[email protected]": {
"deps": [
Expand Down Expand Up @@ -16889,65 +16901,62 @@ PACKAGES = {
"name": "trough",
"url": "https://registry.npmjs.org/trough/-/trough-1.0.5.tgz",
},
"ts-poet@4.6.1": {
"ts-poet@6.11.0": {
"deps": [
{
"id": "@types/[email protected]",
},
{
"id": "[email protected]",
},
{
"id": "[email protected]",
"id": "[email protected]",
},
],
"extra_deps": {
},
"integrity": "sha512-DXJ+mBJIDp+jiaUgB4N5I/sczHHDU2FWacdbDNVAVS4Mh4hb7ckpvUWVW7m7/nAOcjR0r4Wt+7AoO7FeJKExfA==",
"integrity": "sha512-r5AGF8vvb+GjBsnqiTqbLhN1/U2FJt6BI+k0dfCrkKzWvUhNlwMmq9nDHuucHs45LomgHjZPvYj96dD3JawjJA==",
"name": "ts-poet",
"url": "https://registry.npmjs.org/ts-poet/-/ts-poet-4.6.1.tgz",
"url": "https://registry.npmjs.org/ts-poet/-/ts-poet-6.11.0.tgz",
},
"ts-proto-descriptors@1.3.1": {
"ts-proto-descriptors@1.9.0": {
"deps": [
{
"id": "[email protected]",
},
{
"id": "[email protected].2",
"id": "[email protected].4",
},
],
"extra_deps": {
},
"integrity": "sha512-Cybb3fqceMwA6JzHdC32dIo8eVGVmXrM6TWhdk1XQVVHT/6OQqk0ioyX1dIdu3rCIBhRmWUhUE4HsyK+olmgMw==",
"integrity": "sha512-Ui8zA5Q4Jnq6JIGRraUWvECrqixxtwwin8GkhIkvwCpR+JcSPsxWe8HfTj5eHfyruGYI6Zjf96XlC87hTakHfQ==",
"name": "ts-proto-descriptors",
"url": "https://registry.npmjs.org/ts-proto-descriptors/-/ts-proto-descriptors-1.3.1.tgz",
"url": "https://registry.npmjs.org/ts-proto-descriptors/-/ts-proto-descriptors-1.9.0.tgz",
},
"ts-proto@1.83.3": {
"ts-proto@1.148.2": {
"deps": [
{
"id": "@types/[email protected]",
},
{
"id": "[email protected]",
},
{
"id": "[email protected]",
},
{
"id": "[email protected]",
},
{
"id": "[email protected].2",
"id": "[email protected].4",
},
{
"id": "ts-poet@4.6.1",
"id": "ts-poet@6.11.0",
},
{
"id": "ts-proto-descriptors@1.3.1",
"id": "ts-proto-descriptors@1.9.0",
},
],
"extra_deps": {
},
"integrity": "sha512-r6MKFjoc4Og2kB4cNJ/bddLebdIwhouG5plu0Rry1jJMEqp2GKA7AE4FrR/FnTCIGbNPYP4622lBqckZd7UHcQ==",
"integrity": "sha512-sd3STxwE6/6VpASSFnIySID2lkVGwqUU9gnz0Vr1DmB83VjlJpVSeCuEj6UHsrKy7AU2UxchOfcM95LJh0uwjg==",
"name": "ts-proto",
"url": "https://registry.npmjs.org/ts-proto/-/ts-proto-1.83.3.tgz",
"url": "https://registry.npmjs.org/ts-proto/-/ts-proto-1.148.2.tgz",
},
"[email protected]": {
"deps": [
Expand Down Expand Up @@ -17889,19 +17898,19 @@ ROOTS = [
"name": "prettier-plugin-organize-imports",
},
{
"id": "prettier@3.1.1",
"id": "prettier@3.4.2",
"name": "prettier",
},
{
"id": "[email protected].2",
"id": "[email protected].4",
"name": "protobufjs",
},
{
"id": "[email protected]",
"name": "reflect-metadata",
},
{
"id": "[email protected].1",
"id": "[email protected].2",
"name": "rollup",
},
{
Expand All @@ -17913,7 +17922,7 @@ ROOTS = [
"name": "tar-stream",
},
{
"id": "ts-proto@1.83.3",
"id": "ts-proto@1.148.2",
"name": "ts-proto",
},
{
Expand Down
Loading