Skip to content

Add support acceptance-tests #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bin/ris-test-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ const createDebug = require('debug')

const InitCommand = require('../src/commands/init')
const RunCommand = require('../src/commands/run')
const AcceptanceCommand = require('../src/commands/acceptance')

const commands = [
InitCommand,
RunCommand,
AcceptanceCommand,
]

const logError = createDebug('rispa:error:test-utils')
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"@rispa/cli": "latest",
"debug": "^2.6.8",
"fs-extra": "^3.0.1",
"listr": "^0.12.0"
"listr": "^0.12.0",
"axios": "^0.16.1"
},
"devDependencies": {
"@rispa/eslint-config": "^1.1.0"
Expand Down
60 changes: 60 additions & 0 deletions src/commands/acceptance.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
const Listr = require('listr')
const path = require('path')
const Command = require('@rispa/cli/src/Command')
const { PROJECT_NAME } = require('../constants')
const webpackBuild = require('../scenarios/webpackBuild')
const storybookBuild = require('../scenarios/storybookBuild')
const startServer = require('../scenarios/startServer')

const scenarios = {
'webpack-build': webpackBuild,
'storybook-build': storybookBuild,
'start-server': startServer,
}

class AcceptanceCommand extends Command {
constructor([...scenarioNames], options) {
super(options)

this.state = {
scenarioNames,
}
}

init() {
const { scenarioNames } = this.state

this.add([
{
title: 'Init',
task: ctx => {
const { cwd } = ctx

ctx.projectPath = path.resolve(cwd, `../${PROJECT_NAME}`)
},
},
{
title: 'Run scenarios',
skip: () => !process.env.CI_ACCEPTANCE && 'Acceptance tests disabled',
task: () => {
const scenarioList = scenarioNames.map(name => ({ name, task: scenarios[name] }))

const invalidScenarioList = scenarioList
.filter(scenario => !scenario.task)
.map(scenario => scenario.name)

if (invalidScenarioList.length > 0) {
throw new Error(`Can't find scenarios: ${invalidScenarioList.join(', ')}`)
}

return new Listr(scenarioList.map(scenario => scenario.task))
},
},
])
}
}

AcceptanceCommand.commandName = 'acceptance'
AcceptanceCommand.commandDescription = 'Run acceptance scenario'

module.exports = AcceptanceCommand
38 changes: 38 additions & 0 deletions src/scenarios/startServer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
const { runPackageScript } = require('../utils/cli')
const axios = require('axios')

const TIMEOUT = 30000

const webpackBuild = {
title: 'Start server test',
task: ({ projectPath }) => {
const startTime = Date.now()
const server = runPackageScript(projectPath, 'server', 'start-dev')

return new Promise((resolve, reject) => {
let timeout
const failed = error => {
reject(error instanceof Error ? error : 'Failed start server')
clearTimeout(timeout)
}

const startTimeout = () => {
timeout = setTimeout(
() => axios.get('localhost:3000')
.then(resolve, () => {
if (Date.now() - startTime > TIMEOUT) {
failed('Server did not respond')
} else {
startTimeout()
}
}),
100,
)
}

server.then(failed, failed)
})
},
}

module.exports = webpackBuild
8 changes: 8 additions & 0 deletions src/scenarios/storybookBuild.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const { runPackageScript } = require('../utils/cli')

const storybookBuild = {
title: 'Storybook build test',
task: ({ projectPath }) => runPackageScript(projectPath, 'ui', 'build-storybook'),
}

module.exports = storybookBuild
8 changes: 8 additions & 0 deletions src/scenarios/webpackBuild.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const { runPackageScript } = require('../utils/cli')

const webpackBuild = {
title: 'Webpack build test',
task: ({ projectPath }) => runPackageScript(projectPath, 'webpack', 'build'),
}

module.exports = webpackBuild
2 changes: 1 addition & 1 deletion src/utils/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const createProject = (path, projectName) => runCommand(
options
)

const runPackageScript = (projectPath, pluginName, scriptName, args) => runCommand(
const runPackageScript = (projectPath, pluginName, scriptName, args = []) => runCommand(
'run',
[pluginName, scriptName, ...args],
{
Expand Down