Skip to content

feat(optimizer): support enforcing locality on the reqirement side #23401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

feat(optimizer): support enforcing locality on the reqirement side #23401

merged 1 commit into from
Oct 10, 2025

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Oct 10, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@chenzl25 chenzl25 changed the title support enforcing locality on the reqirement side feat(optimizer): support enforcing locality on the reqirement side Oct 10, 2025
This was referenced Oct 10, 2025
Merged
Merged
@chenzl25 Graphite App
Copy link
Contributor Author

chenzl25 commented Oct 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added type/feature Type: New feature. and removed Invalid PR Title labels Oct 10, 2025
@chenzl25 chenzl25 marked this pull request as ready for review October 10, 2025 05:32
@chenzl25 chenzl25 mentioned this pull request Oct 10, 2025
Open
7 tasks
@chenzl25 chenzl25 requested a review from BugenZhao October 10, 2025 05:32
chenzl25
chenzl25 commented Oct 10, 2025
View reviewed changes
src/frontend/src/optimizer/plan_node/logical_join.rs
}
}

fn try_better_locality_inner(&self, columns: &[usize]) -> Option<PlanRef> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just move the inner function to the outside, no changes.

src/frontend/src/optimizer/plan_node/logical_scan.rs
None
}

fn try_better_locality_inner(&self, columns: &[usize]) -> Option<PlanRef> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just move the inner function to the outside, no changes.

Base automatically changed from dylan/support_locality_enforcement to main October 10, 2025 05:47
@chenzl25 chenzl25 force-pushed the dylan/support_enforce_locality_on_the_requirement_side branch from 91bcc9b to 20fbdbd Compare October 10, 2025 06:08
BugenZhao
BugenZhao approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenzl25 chenzl25 added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit 953a006 Oct 10, 2025
33 of 34 checks passed
@chenzl25 chenzl25 deleted the dylan/support_enforce_locality_on_the_requirement_side branch October 10, 2025 10:13
@chenzl25 chenzl25 mentioned this pull request Oct 14, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenzl25 @BugenZhao