Skip to content

Conversation

WanYixian
Copy link
Collaborator

@WanYixian WanYixian commented Sep 19, 2025

Description

See preview of manage secrets and create secret command.

Related code PR

risingwavelabs/risingwave#22627

Related doc issue

Fix #663

Checklist

  • I have run the documentation build locally to verify the updates are applied correctly.
  • For new pages, I have updated mint.json to include the page in the table of contents.
  • All links and references have been checked and are not broken.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation to reflect the addition of HashiCorp Vault as a backend option for creating secrets in RisingWave. The changes expand the secret management documentation to include comprehensive syntax, parameters, and examples for both the existing meta backend and the new hashicorp_vault backend.

  • Added complete documentation for HashiCorp Vault backend configuration including authentication methods (token and AppRole)
  • Updated syntax examples and parameter tables to cover both backend options
  • Reorganized the documentation structure with clearer sections for each backend type

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
sql/commands/sql-create-secret.mdx Added comprehensive HashiCorp Vault backend documentation with syntax, parameters, and examples
operate/manage-secrets.mdx Updated to reference both backend options and removed outdated limitation note

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: IrisWan <[email protected]>
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@WanYixian WanYixian merged commit 80237ab into main Sep 23, 2025
4 checks passed
@WanYixian WanYixian deleted the wyx/fix-663 branch September 23, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: feat: hashicorp_vault as secret backend
2 participants