-
Notifications
You must be signed in to change notification settings - Fork 13
Document: hashicorp_vault
as backend when creating secret
#697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation to reflect the addition of HashiCorp Vault as a backend option for creating secrets in RisingWave. The changes expand the secret management documentation to include comprehensive syntax, parameters, and examples for both the existing meta
backend and the new hashicorp_vault
backend.
- Added complete documentation for HashiCorp Vault backend configuration including authentication methods (token and AppRole)
- Updated syntax examples and parameter tables to cover both backend options
- Reorganized the documentation structure with clearer sections for each backend type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
sql/commands/sql-create-secret.mdx | Added comprehensive HashiCorp Vault backend documentation with syntax, parameters, and examples |
operate/manage-secrets.mdx | Updated to reference both backend options and removed outdated limitation note |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: IrisWan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Description
See preview of manage secrets and create secret command.
Related code PR
risingwavelabs/risingwave#22627
Related doc issue
Fix #663
Checklist
mint.json
to include the page in the table of contents.