fix(trayicon): explorer.exe hangs #1522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotem
reviewed
Mar 26, 2025
| @@ -116,7 +116,7 @@ void _RefreshTrayIcon(const RimeSessionId session_id, | |||
| static char app_name[50]; | |||
| rime_api->get_property(session_id, "client_app", app_name, | |||
| sizeof(app_name) - 1); | |||
| if (u8tow(app_name) == std::wstring(L"explorer.exe")) | |||
| if (u8tow(app_name) == std::wstring(L"explorer.exe") || !app_name[0]) | |||
There was a problem hiding this comment.
!app_name[0] 竟有這種情況，那是不是應該先測非空再轉碼、比較？
There was a problem hiding this comment.
确实应该先测非空。
但为啥为空我还没找出来，这段时间都没空调试，也许应该先找找为空的原因，从根源上解决。
There was a problem hiding this comment.
空的上一步，可能是RimeWithWeaselHandler::_ReadClientInfo中有
if (!app_name.empty()) {
rime_api->set_property(session_id, "client_app", app_name.c_str());然后 get_property其实是个Bool返回的接口，应该将这个返回用起来这样
|
如果这个有效，那很可能会关闭 #938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
应该可以修复托盘图标卡死 explorer.exe，其实是卡住 7 秒。
我这里测试是不卡了，还需要更多测试。