Enhances delay expression support #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates FeatureDetector to mark send_delay_expressions as :supported - Adds detection for delay attribute alongside existing delayexpr support - Converts 4 SCION delayedSend tests to use StateMachine for async delays - Analysis shows most delay-based tests use delays as safeguards, not timing drivers - Fixes regex pattern in mix test.update_features to handle multiline @tag blocks - Prevents creation of duplicate @tag required_features: lines - Adds intelligent formatting (single-line vs multiline based on length) - Removes 96 duplicate tags created by previous runs - Adds comprehensive test coverage for delay expression detection - Updates 99 test files with proper @tag required_features: annotations - Maintains clean code formatting with proper line length limits 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Adds proper process lifecycle management and error handling for the 'invalid delay expression defaults to 0ms' test to prevent GenServer stop errors in CI environments. - Adds process aliveness check before state assertions - Includes explicit cleanup in try/after block - Increases sleep timeout for CI timing differences 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates FeatureDetector to mark send_delay_expressions as :supported
Adds detection for delay attribute alongside existing delayexpr support
Converts 4 SCION delayedSend tests to use StateMachine for async delays
Analysis shows most delay-based tests use delays as safeguards, not timing drivers
Fixes regex pattern in mix test.update_features to handle multiline tag blocks
Prevents creation of duplicate tag required_features: lines
Adds intelligent formatting (single-line vs multiline based on length)
Removes 96 duplicate tags created by previous runs
Adds comprehensive test coverage for delay expression detection
Updates 99 test files with proper tag required_features: annotations
Maintains clean code formatting with proper line length limits
🤖 Generated with Claude Code