Implements event processing improvements #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds error.execution event generation in AssignAction per SCXML specification and implements SCXML-compliant event matching patterns in Event.matches/2. Changes: - AssignAction: Generate error.execution events on assignment failures - Event: Implement prefix matching, wildcards, and universal wildcard patterns - Supports "foo bar" (OR patterns), "foo.*" (wildcard suffix), "*" (universal) Test Results: - test399 now passes (SCXML event matching compliance) - W3C tests: 26/59 passing (maintained from Phase 1) - Known regression: test387 (1 test, will address separately) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Changes nested assignments to fail when intermediate structures don't exist, generating error.execution events per SCXML spec instead of auto-creating intermediate maps. Changes: - Strict checking in Datamodel.put_in_path/3 - Enhanced location validation with whitespace checking - Updated internal tests to match correct SCXML behavior Results: test401 now passes, W3C tests 27/59 (+1), all regression tests pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds error.execution event generation in AssignAction per SCXML specification
and implements SCXML-compliant event matching patterns in Event.matches/2.
Changes:
Changes nested assignments to fail when intermediate structures don't exist,
generating error.execution events per SCXML spec instead of auto-creating
intermediate maps.
Changes: