-
Notifications
You must be signed in to change notification settings - Fork 1
WIP: Implemented RGPM Interface and other fixes #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oparkins
wants to merge
36
commits into
master
Choose a base branch
from
issue/#16
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore the failing builds right now... There appears to be an issue with Travis-CI Xenial image. I put in a comment at https://travis-ci.community/t/xenial-kernel-does-not-appear-to-have-sandbox-capabilities/5370. |
Since the storage-integrations repo has a npm package on github, yarn has been configured to use the github repo.
It looks like these changes may need to be rebased onto master. It seems like there are duplicate changes here as in #17. |
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.2.0 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.2.0...v4.5.3) Signed-off-by: dependabot[bot] <[email protected]>
…rs-4.5.3' into issue/#16
Updated dependencies using yarn upgrade --latest. The tests passed. This was to fix some security issues that were mentioned by GitHub
I moved the tests to where the actual crypto lib will get tested. This also makes sure that the methods are accessible in the library itself and that the functions work across different javascript platforms. (even though that is technically not necessary)
…lementations Had to add storage-integrations as a dependency. Ran into an issue where the webpack version upgrade failed testing. I had to change the webpack config to get it to work again.
When initializing the RGPM class, it will now determine which storage location should be used. The default is local storage and when it is the first time the class has ever been initialized, it will use the local storage as well.
The verify method doesn't deal with crypto, but instead uses it. This is like the other functions inside of rgpm. In addition, by moving the method to rgpm, it allows for the test cases to be simplier and cleaner by not duplicated password specifications through the test files
…suit the algorithms that use them Instead of converting everything to hex each time we needed to use it, I made the crypto functions able to use the output of the other crypto functions. This was a problem that was seen during testing of initPass in rgpm.js.
irremotus
requested changes
Dec 30, 2019
Implemented the record CRUD operations which also includes test cases. Added the genPass algorithm as well. This will mark the end of the major development of the core, and where the GUI work starts
… count if it is different than 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the webpack bundle. Do this pull request after #17