FIX: Show settings cog only if user has permissions, add InviteOthers #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asraye <[email protected]>
2 tasks
insertish
requested changes
Aug 29, 2025
Comment on lines
329
to
338
| // determine if user can edit channel (any relevant permission) | ||
| const canEditChannel = [ | ||
| "ManageChannel", | ||
| "ManagePermissions", | ||
| "ManageWebhooks", | ||
| ].some((perm) => props.channel.server?.havePermission(perm)); | ||
|
|
||
| // user can create invites?? | ||
| const canInvite = props.channel.server?.havePermission("InviteOthers"); | ||
|
|
There was a problem hiding this comment.
Solid.js components run once, so these should be in functions to be reactive afaik
i.e. () => yourCheck and then canInvite() where it is used
There was a problem hiding this comment.
Updated the channel permission and invite checks to use createMemo
github-project-automation
bot
moved this from 🆕 Untriaged
to 🛑 Changes requested
in Pull Request Overview
Signed-off-by: Asraye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to push the change to this, accidently opened a new PR (woops), adds strings for settings cog, and also adds a check for invite permissions
Please make sure to check the following tasks before opening and submitting a PR