Skip to content

[CLI] Various improvements to batch cancel/kill and co. #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slinkydeveloper wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[CLI] Various improvements to batch cancel/kill and co. #3943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42f37c1
Add a limit to the batch cancel/kill and co. Mitigates #3857
slinkydeveloper Nov 4, 2025
bc7f278
Introduce a utility for running concurrent `map` on a stream, limitin…
slinkydeveloper Nov 4, 2025
4cfe09f
Assorted improvements to cancel/kill:
slinkydeveloper Nov 4, 2025
3226a75
Whatev CI asked me to do
slinkydeveloper Nov 4, 2025
49d7938
Feedback
slinkydeveloper Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ restate-cli-util = { workspace = true }
restate-cloud-tunnel-client = { workspace = true }
restate-serde-util = { workspace = true }
restate-time-util = { workspace = true }
restate-futures-util = { workspace = true }
restate-types = { workspace = true }
restate-lite = { workspace = true, optional = true }
mock-service-endpoint = { workspace = true, optional = true }
Expand Down
24 changes: 14 additions & 10 deletions cli/src/clients/admin_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,36 +283,40 @@ impl AdminClient {
}

/// Execute a request and return the response as a lazy Envelope.
pub(crate) async fn run<T>(
pub(crate) fn run<T>(
&self,
method: reqwest::Method,
path: Url,
) -> reqwest::Result<Envelope<T>>
) -> impl Future<Output = reqwest::Result<Envelope<T>>> + 'static
where
T: DeserializeOwned + Send,
{
debug!("Sending request {} ({})", method, path);
let request = self.prepare(method, path.clone());
let resp = request.send().await?;
debug!("Response from {} ({})", path, resp.status());
Ok(resp.into())
async move {
let resp = request.send().await?;
debug!("Response from {} ({})", path, resp.status());
Ok(resp.into())
}
}

pub(crate) async fn run_with_body<T, B>(
pub(crate) fn run_with_body<T, B>(
&self,
method: reqwest::Method,
path: Url,
body: B,
) -> reqwest::Result<Envelope<T>>
) -> impl Future<Output = reqwest::Result<Envelope<T>>> + 'static
where
T: DeserializeOwned + Send,
B: Serialize + std::fmt::Debug + Send,
{
debug!("Sending request {} ({}): {:?}", method, path, body);
let request = self.prepare_with_body(method, path.clone(), body);
let resp = request.send().await?;
debug!("Response from {} ({})", path, resp.status());
Ok(resp.into())
async move {
let resp = request.send().await?;
debug!("Response from {} ({})", path, resp.status());
Ok(resp.into())
}
}
}

Expand Down
Loading
Loading