Add new process to apply TRestDataSetGainMap to track line #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanangp
reviewed
Oct 1, 2025
| // apply calibration from gainmap | ||
| TRestTrack* tckXYZcalibrated = new TRestTrack(); | ||
| TRestVolumeHits* hitsXYZcalibrated = new TRestVolumeHits(); | ||
| for (int i = 0; i < hitsXYZ->GetNumberOfHits(); i++) { |
Member
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < hitsXYZ->GetNumberOfHits(); i++) { | |
| for (size_t i = 0; i < hitsXYZ->GetNumberOfHits(); i++) { |
juanangp
reviewed
Oct 1, 2025
| double zClosestYhit = 9e9; | ||
| double eClosestYhit = 0; | ||
| double yClosestYhit = 0; | ||
| for (int j = 0; j < hitsY->GetNumberOfHits(); j++) { |
Member
There was a problem hiding this comment.
Suggested change
| for (int j = 0; j < hitsY->GetNumberOfHits(); j++) { | |
| for (size_t j = 0; j < hitsY->GetNumberOfHits(); j++) { |
juanangp
reviewed
Oct 1, 2025
| TRestVolumeHits* hitsXYZ = new TRestVolumeHits(); | ||
| auto hitsX = tckX->GetHits(); | ||
| auto hitsY = tckY->GetHits(); | ||
| for (int i = 0; i < hitsX->GetNumberOfHits(); i++) { |
Member
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < hitsX->GetNumberOfHits(); i++) { | |
| for (size_t i = 0; i < hitsX->GetNumberOfHits(); i++) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new process TRestTrackLineGainMapCorrectionProcess applies the calibration of a TRestDataSetGainMap to a TRestTrackEvent which should have been already linearized (by the process TRestTrackLinearizationProcess). The key point of this process is that it applies the gain map hit by hit (where this hits are the nodes of the linearized track).
Note
Suggestions for the process name are welcomed 😅