Skip to content

Avoid metaprogramming when bulk setting attributes. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid metaprogramming when bulk setting attributes. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions lib/json_api_client/helpers/dynamic_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def attributes=(attrs = {})

return @attributes unless attrs.present?
attrs.each do |key, value|
send("#{key}=", value)
self[key] = value
end
end

Expand All @@ -20,7 +20,8 @@ def [](key)
end

def []=(key, value)
set_attribute(key, value)
normalized_key = normalize_name(key)
set_attribute(normalized_key, value)
end

def respond_to_missing?(method, include_private = false)
Expand All @@ -37,12 +38,16 @@ def has_attribute?(attr_name)

protected

def normalize_name(name)
if key_formatter
key_formatter.unformat(name.to_s)
else
name.to_s
end
end

def method_missing(method, *args, &block)
normalized_method = if key_formatter
key_formatter.unformat(method.to_s)
else
method.to_s
end
normalized_method = normalize_name(method)

if normalized_method =~ /^(.*)=$/
set_attribute($1, args.first)
Expand Down