Fix issue with partial application and user defined types. #7548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7544 Fix an issue in type checking partial application in the presence of user-defined function types. The type checking code, when extracting the arity of the type annotation given to a function being applied, was expecting a concrete function type instead of looking up a possible type definition.
cristianoc
force-pushed
the
partial-app-type-def
branch
from
92b6e8f to
4d4b58b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in type checking for partial application when using user-defined function types. It adds tests in both ReScript and JavaScript for partial application with a user-defined type, and adjusts the type extraction logic in the compiler to look up the proper function type arity.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/tests/src/PartialApplicationNoRuntimeCurry.res | Adds tests for partial application with a user-defined function type. |
| tests/tests/src/PartialApplicationNoRuntimeCurry.mjs | Adds corresponding JS tests for partial application. |
| compiler/ml/typecore.ml | Updates type extraction logic to correctly handle user-defined types. |
| CHANGELOG.md | Updates the changelog to reflect the fix. |
Comments suppressed due to low confidence (1)
tests/tests/src/PartialApplicationNoRuntimeCurry.res:10
- [nitpick] The new definition of 'add' may shadow the earlier function 'add' defined on line 1. Consider renaming it (e.g., 'add2' or 'add_fn2') to avoid potential confusion in the test file.
let add: fn2 = (a, b) => a + b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7544
Fix an issue in type checking partial application in the presence of user-defined function types. The type checking code, when extracting the arity of the type annotation given to a function being applied, was expecting a concrete function type instead of looking up a possible type definition.