feat: Add listCustomersByEmail and fix API response parsing #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `listCustomersByEmail` function to search customers by email address - Refactor `listCustomersByName` and `listCustomersByEmail` to share common `searchCustomers` helper function, eliminating code duplication - Fix API response parsing to use correct field names: - Use `customers` array instead of `data` - Use `total_hits` instead of `total_count` - Update all test mocks to match actual API response format - Add test script (`examples/test-list-customers-by-name.ts`) for debugging customer search functionality The previous implementation was looking for `data` and `total_count` fields that the API never returns, causing searches to return empty results even when customers existed.
nvanthao
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listCustomersByEmailfunction to search customers by email addresslistCustomersByNameandlistCustomersByEmailto share commonsearchCustomershelper function, eliminating code duplicationcustomersarray instead ofdatatotal_hitsinstead oftotal_countexamples/test-list-customers-by-name.ts) for debugging customer search functionalityThe previous implementation was looking for
dataandtotal_countfields that the API never returns, causing searches to return empty results even when customers existed.