Prepare procedure source URL for remote tarballs #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
8W9aG
commented
Jun 9, 2025
8W9aG
commented
- If someone has a URL path for a procedure that contains multiple directories this currently fail
- Hash the path so the directories are standardised
nevillelyh
reviewed
Jun 9, 2025
internal/server/server.go
Outdated
| @@ -203,7 +205,8 @@ func (h *Handler) Predict(w http.ResponseWriter, r *http.Request) { | |||
| http.Error(w, "invalid procedure_source_url", http.StatusBadRequest) | |||
| return | |||
| } | |||
| srcDir := u.Path | |||
| hash := md5.Sum([]byte(u.Path)) | |||
There was a problem hiding this comment.
We use SHA256 in most places. Do that for consistency? Performance is not an issue here.
There was a problem hiding this comment.
We were assuming req.ProcedureSourceURL was a file:///<path> type local path that already exists.
But here we should probably dome something like:
var srcDir string
if u.Scheme == "file" {
srcDir = u.Path
}
else {
// URL is (http|https)://...
sha := <sha sum of URL>
srcDir = path.Join(os.TempDir(), "procedure-" + sha)
os.MkdirAll(srcDir)
<pget -x URL srcDir>
}
There was a problem hiding this comment.
pget -x <URL> <dir> creates the <dir> so don't even need os.MkdirAll
internal/server/runner.go
Outdated
| @@ -120,6 +120,7 @@ func NewRunner(awaitExplicitShutdown bool, uploadUrl string) *Runner { | |||
|
|
|||
| func NewProcedureRunner(awaitExplicitShutdown bool, uploadUrl string, srcDir string) *Runner { | |||
| r := NewRunner(awaitExplicitShutdown, uploadUrl) | |||
| os.Mkdir(srcDir, 0o755) | |||
There was a problem hiding this comment.
I'd move this to server.go where we hash URL & extract tarball. Runner should always assume dir is prepared.
* If someone has a URL path for a procedure that contains multiple directories this currently fail * Hash the path so the directories are standardised
nevillelyh
force-pushed
the
sackfield/hash-src-dir
branch
from
4f8d514 to
f870ab9
Compare
nevillelyh
changed the title
nevillelyh
force-pushed
the
sackfield/hash-src-dir
branch
4 times, most recently
from
d7508d1 to
3f985d8
Compare
nevillelyh
force-pushed
the
sackfield/hash-src-dir
branch
from
3f985d8 to
e10a9c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.