Skip to content

Conversation

guivr
Copy link

@guivr guivr commented Jan 20, 2025

Fixes #244

@guivr
Copy link
Author

guivr commented Jan 28, 2025

Update: now it hashes filenames and only download .safetensors files

@guivr
Copy link
Author

guivr commented Jan 30, 2025

Is there anything I need to work on to get this approved? @fofr

I need this to use it in my business (currently using a custom cog)

Thanks

@guivr
Copy link
Author

guivr commented Feb 1, 2025

I tried to improve the code + keep the original filename in the beginning of the final filename so that the logs from WeightsDownloader are easier to read and identify which lora it is downloading.

@guivr
Copy link
Author

guivr commented Feb 13, 2025

@fofr what do I need to do?

@guivr
Copy link
Author

guivr commented Feb 19, 2025

@fofr Hi fofr, you said you’d fix this (#237)

how do you suggest fixing it if not this way?

@guivr
Copy link
Author

guivr commented Mar 9, 2025

any feedback?

@guivr
Copy link
Author

guivr commented Apr 9, 2025

@fofr what's missing for this to get approved? Why are there no responses? What's wrong with it?

@jordancoult
Copy link

@guivr Can you push to your own fork if you need this urgently?

@guivr
Copy link
Author

guivr commented Apr 10, 2025

@guivr Can you push to your own fork if you need this urgently?

Yes it's possible but then I have to use my own cog, and it always gets cold/sleeps. any-comfyui is usually warm and starts up faster (less costs)

I think this update is beneficial to everyone because the LoRA Stacker is a node listed as supported by this cog, but it's not fully supported - because it can't load custom LoRA URLs - but this pull request fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom lora URLs in LoRA Stacker + Efficient Loader nodes
2 participants