-
Notifications
You must be signed in to change notification settings - Fork 198
Add support for custom lora urls in LoRA Stacker #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update: now it hashes filenames and only download .safetensors files |
Is there anything I need to work on to get this approved? @fofr I need this to use it in my business (currently using a custom cog) Thanks |
I tried to improve the code + keep the original filename in the beginning of the final filename so that the logs from WeightsDownloader are easier to read and identify which lora it is downloading. |
@fofr what do I need to do? |
any feedback? |
@fofr what's missing for this to get approved? Why are there no responses? What's wrong with it? |
@guivr Can you push to your own fork if you need this urgently? |
Yes it's possible but then I have to use my own cog, and it always gets cold/sleeps. any-comfyui is usually warm and starts up faster (less costs) I think this update is beneficial to everyone because the LoRA Stacker is a node listed as supported by this cog, but it's not fully supported - because it can't load custom LoRA URLs - but this pull request fixes it. |
Fixes #244