Bring over RR session code into @remix-run/session package #10797
Conversation
brophdawg11
force-pushed
the
brophdawg11/session
branch
from
003723b to
80537fe
Compare
brophdawg11
force-pushed
the
brophdawg11/session
branch
2 times, most recently
from
9dc0e74 to
d15afe1
Compare
brophdawg11
force-pushed
the
brophdawg11/session
branch
2 times, most recently
from
0e06933 to
62f95fa
Compare
…t of fetch-router in the browser bundle
brophdawg11
force-pushed
the
brophdawg11/session
branch
from
62f95fa to
7350dde
Compare
| @@ -0,0 +1 @@ | |||
| export { createFileSessionStorage } from './lib/storage/file-storage.ts' | |||
There was a problem hiding this comment.
I needed to move this to a sub-export so that it didn't get picked up when a client-side API imported @remix-run/fetch-router and @remix-run/fetch-router importing the agnostic session stuff from @remix-run/sesson.
This happened from the bookstore routes.ts:
import { route, formAction, resources } from '@remix-run/fetch-router'
export let routes = route({ ... })When we tried to run pnpm dev:browser, it would error on the file-storage imports of node:fs
| // Store carts by cartId, cartId will be stored in the session | ||
| let nextCartId = 1 |
There was a problem hiding this comment.
No longer storing by session id because that's not something app code can always directly access (sesson.id isn't populated on initial session creation - only when we eventually commit the session). We don't want to commit a session until they interact with it, so there's no good way to key a cart by sessionId the first time we interact with the session. Instead, we use a cartId that we store in the session (which "activates" the session and triggers the cookie), and we key the cart lookup by that.
| * To be used on any route that mutates the cart | ||
| */ | ||
| export const ensureCart: Middleware = async ({ session }) => { | ||
| createCartIfNotExists(session) |
There was a problem hiding this comment.
Middleware used by the cart API routes to ensure we always have a cart available if we're trying to mutate the cart
| declare module '@remix-run/session' { | ||
| interface SessionData { | ||
| cartId?: string | ||
| userId?: string |
There was a problem hiding this comment.
Module augmentation to strongly type our session
| async add({ storage, formData }) { | ||
| // Simulate network latency | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)) | ||
| use: [ensureCart], |
There was a problem hiding this comment.
Cart middleware that runs before all cart API handlers
Stacked on #10796
Adds a new
@remix-run/sessionpackage - brought over from https://github.com/remix-run/react-router/blob/main/packages/react-router/lib/server-runtime/sessions.ts