Skip to content

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Aug 21, 2025

Purpose of this PR

This deletes no longer used variables and equations and moves some parameters to modules.

Moved:

  • pm_share_trans -> p11_share_trans
  • o_INI_DirProdSeTe -> o05_INI_DirProdSeTe

Deleted:

  • p_pvpRegiBeforeStartYear, o_emissions_.., o_capture_.., o_carbon_.. , q_limitSo2
  • scripts/utils/gdx_rename.sh (outdated script by Antoine)

None of the renamed or deleted variables seem to be referenced in the remind2 reporting.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ☑️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ☑️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@fbenke-pik fbenke-pik changed the title Refactor Move parameters to modules Aug 22, 2025
@fbenke-pik fbenke-pik marked this pull request as ready for review August 22, 2025 11:41
@fbenke-pik fbenke-pik merged commit 7f165ea into remindmodel:develop Aug 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants