Move parameters to modules #2186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This deletes no longer used variables and equations and moves some parameters to modules.
Moved:
pm_share_trans
->p11_share_trans
o_INI_DirProdSeTe
->o05_INI_DirProdSeTe
Deleted:
p_pvpRegiBeforeStartYear
,o_emissions_..
,o_capture_..
,o_carbon_..
,q_limitSo2
scripts/utils/gdx_rename.sh
(outdated script by Antoine)None of the renamed or deleted variables seem to be referenced in the remind2 reporting.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test
) after my final commit and all tests pass (FAIL 0
)remind2
if and where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.md
correctly (added, changed, fixed, removed, input data/calibration)Further information (optional)