Skip to content

Conversation

robertsalzwedel
Copy link
Contributor

@robertsalzwedel robertsalzwedel commented Jul 28, 2025

Purpose of this PR

In PR 2034, the efficiency of the gasftcrec process was decreased. This should have affected the emission factors according to the formula:

Capture Rate(tech) = Emifac(input) * 0.9 - Emifac(output) / 0.95 * Efficiency(tech)

which can be found in the bottem of generisdata_emi.

As this wasnt done back then, this fixes the inconsistency.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ◻️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ☑️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ☑️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ☑️ Change of parameter values or input data (including CES parameters)
  • ☑️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@robertsalzwedel robertsalzwedel self-assigned this Jul 28, 2025
@robertsalzwedel robertsalzwedel added the bug Something isn't working label Jul 28, 2025
Copy link
Contributor

@fschreyer fschreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Is this pm_emifac(gasftcrec) > pm_emifac(gasftrec) issue solved / weakened with this?

@robertsalzwedel
Copy link
Contributor Author

Nice! Is this pm_emifac(gasftcrec) > pm_emifac(gasftrec) issue solved / weakened with this?

I will doublecheck, it might :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants