-
Notifications
You must be signed in to change notification settings - Fork 147
Process-based chemicals #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
leonieschweiger
wants to merge
97
commits into
remindmodel:develop
Choose a base branch
from
leonieschweiger:chemicals
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Process-based chemicals #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date_documentation2
…o include OtherChem in o37_demFeIndRoute
…a.R accepting incoming change
Add documentation for CAPEX/OPEX of Chemical Processes
fix bug on calibration
add documentation to the process-based chemicals implementation and update specificFeDemands in datainput.gms; fix a bug in postsolve.gms in the calculation of o37_shIndFE
Make the chemicals branch work with cm_subsec_model_chemicals ces, fix bug in feedstock demand balance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Process-based implementation of basic chemicals production.
Requires pik-piam/mrindustry#54.
Still in development.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test
) after my final commit and all tests pass (FAIL 0
)remind2
if and where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.md
correctly (added, changed, fixed, removed, input data/calibration)Further information (optional)