Allow for removal of Bing Maps session #708
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`baseLayer: false` has different behavior from `baseLayer: undefined`, so the existing code wasn't allowing for disabling the Bing Maps baseLayer. Removed the destructured baseLayer prop so it just gets passed in with `...props`. Left the check for baseLayer.removeAll() since it's not hurting anything. See https://cesium.com/learn/ion/optimizing-quotas/#optimizing-bing-maps-sessions and https://cesium.com/learn/ion-sdk/ref-doc/Viewer.html#.ConstructorOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, even with
baseLayer={false}andbaseLayerPicker={false}, the<Viewer />ends up creating a Bing Maps session. Can confirm by observing a request made todev.virtualearth.netin the browser Network tab.This PR resolves #707 by allowing
baseLayer: falseto pass into theCesium.Viewerconstructor.Details
baseLayer: falsehas different behavior frombaseLayer: undefined, so the existing code wasn't allowing for disabling the default Bing Maps baseLayer.To fix the bug here, I removed the destructured
baseLayerprop so it just gets passed in with...props. I left theimageryLayers.removeAll()since it doesn't appear to be hurting anything.Confirmed this change clears the
dev.virtualearth.netrequest from the Network tab with<Viewer baseLayer={false} baseLayerPicker={false} />.