-
Couldn't load subscription status.
- Fork 58
feat(server): use reearth-accounts api client pkg instead of using self implementation #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6d445e0 to
3fa4f2a
Compare
3fa4f2a to
1450b3c
Compare
…lf implementation
1450b3c to
5f44af8
Compare
70f58d3 to
cb69757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates from an internal accounts infrastructure to using the external reearth-accounts server client library. The changes involve replacing custom GraphQL client code with a standardized client library and updating dependencies.
Key Changes:
- Replaced internal
server/internal/infrastructure/accountspackage withgithub.com/reearth/reearth-accounts/server/pkg/gqlclient - Added new dependency:
github.com/reearth/reearth-accounts/server v0.0.0-20251029041058-19ad61a40385 - Updated numerous Go dependencies to newer versions
- Generated mock for
user.Repointerface using go-mock
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/pkg/user/mockrepo/mockrepo.go | Generated mock implementation for user repository |
| server/internal/infrastructure/accounts/* | Removed internal accounts infrastructure (client, repos, models) |
| server/internal/adapter/gql/resolver.go | Updated to use external gqlclient.Client |
| server/internal/app/*.go | Updated imports and client initialization |
| server/go.mod | Added reearth-accounts dependency and updated dependencies |
| server/go.sum | Updated dependency checksums |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Overview
This branch integrates the Re:Earth Accounts API client
package to replace the self-implemented authentication
system, improving the authentication architecture and
removing code duplication.
Key Changes
Authentication System Refactoring:
github.com/reearth/reearth-accounts/server client
package
client
service (GetMe endpoint)
Notable Files Changed:
New auth transport implementation
accounts API client
user resolver methods
auth flow
Dependency Updates:
dependency
Impact
service
implementation
accounts service
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo