feat(server): modify sampler setting #1880
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexaforce
force-pushed
the
feat/telemetry-tracer-update
branch
from
37081f2 to
6fb80a0
Compare
soneda-yuya
reviewed
Oct 22, 2025
server/internal/app/app.go
Outdated
| return err | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you move this function to app/internal/adapter/middleware?
soneda-yuya
reviewed
Oct 22, 2025
server/internal/app/graphql.go
Outdated
|
|
||
| return next(ctx) | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you move codes related with tracer to server/internal/app/tracer?
pyshx
requested changes
Oct 22, 2025
hexaforce
force-pushed
the
feat/telemetry-tracer-update
branch
from
f523e82 to
b7c217d
Compare
hexaforce
force-pushed
the
feat/telemetry-tracer-update
branch
from
6ca3c73 to
54e0f21
Compare
pyshx
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix the sampler configuration for GCP Tracer.
What I've done
The following changes were made:
1. The parent span for GraphQL was incorrect, causing tracing to fail.
2.Added sampling for REST requests.
What I haven't done
How I tested
Which point I want you to review particularly
Memo