blocking_timeout should default to self.timeout #3728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
Description of change
Default the
blocking_timeout
onLock.acquire
toself.timeout
.I ran into a platform specific error, which prevented redis-py from acquiring a Lock. Although the
timeout
was set, there was noblocking_timeout
. This led to a test suite hanging on an infinite loop, minutes longer than the explicit timeout. There is no reason for a blocking_timeout to ever be longer than the normal timeout.If the acquire succeeds after the Lock.timeout expires, the lock will already fail. This change simply makes that failure instant, and prevents potentially infinite loops.