Revert extraneous local assignment of scheduled tasks #2996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebbyLaw
force-pushed
the
dev/revert-2816
branch
from
897d08a to
3d7350a
Compare
SebbyLaw
force-pushed
the
dev/revert-2816
branch
from
3d7350a to
16413f1
Compare
SebbyLaw
force-pushed
the
dev/revert-2816
branch
from
16413f1 to
123e8d8
Compare
…tially disappearing (redis#2816)" This reverts commit 56b254e.
|
This pull request is marked stale. It will be closed in 30 days if it is not updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 56b254e. (#2816)
Pull Request check-list
Please make sure to review and check all of these items:
Description of change
Scheduled tasks have strong references assigned to them by asyncio. The documentation mentioned is a mistake and is being removed. Furthermore, as mentioned in a comment on the original pull request, these local assignments are not enough to avoid garbage collection.
python/cpython#91887 (comment)
Also see: python/cpython#106203 and Rapptz/discord.py#9472 where the author of this pull request tried to submit a PR for a functional no-op similar to this one and was correctly rejected.