Skip to content

Conversation

romanwu10
Copy link

closes #707

  1. removed the deprecated custom event_loop fixture (no more pytest-asyncio warning)
  2. renamed the shadowing dict field to dict_field (no more Pydantic warning)
  3. regenerated sync code with make_sync.py to keep async/sync tests updated.

@abrookins abrookins requested a review from Copilot September 25, 2025 17:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This refactor addresses two deprecation warnings: removes a deprecated custom event_loop pytest fixture and renames a dict field that was shadowing Python's built-in dict type. The changes maintain test functionality while eliminating warning messages.

  • Removed deprecated custom event_loop fixture from conftest.py
  • Renamed dict field to dict_field in EmbeddedJsonModelWithDict test model
  • Updated all references to use the new field name

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/conftest.py Removes deprecated custom event_loop fixture
tests/test_json_model.py Renames dict field to dict_field and updates all references

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest warnings: pytest-asyncio deprecation and pydantic field shadowing
2 participants