Skip to content

RI-7681: [NEW UI] Connection Settings #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Nov 5, 2025
Merged

RI-7681: [NEW UI] Connection Settings #5127

merged 30 commits into from
Nov 5, 2025

Conversation

@dantovska
Copy link
Collaborator

@dantovska dantovska commented Oct 30, 2025 •
edited
Loading

Add changes to the Connection Settings when adding a database

Applied changes

  • add spacing between the form fields
  • adjust text sizing
  • move the footer to the bottom
  • use required property for the required fields
  • fix the info icon
  • remove info that port should not exceed 65535 as it was breaking layout and it is not needed as there is a constraint
Old New
image image
image image
image image

@dantovska dantovska self-assigned this Oct 30, 2025
@dantovska dantovska force-pushed the fe/feature/RI-7681-form-add-db branch from 50aa856 to a1c37d7 Compare October 31, 2025 13:54
Base automatically changed from fe/feature/RI-7681-form-add-db to main November 3, 2025 07:55
@dantovska dantovska force-pushed the fe/feature/RI-7681-connection-settings branch from e1c8b04 to 28bb562 Compare November 3, 2025 07:59
@dantovska dantovska marked this pull request as ready for review November 3, 2025 14:28
pd-redis
pd-redis reviewed Nov 3, 2025
View reviewed changes
...ome/components/manual-connection/manual-connection-form/forms/DecompressionAndFormatters.tsx
className="form__divider"
/>

<Spacer size="m" />
Copy link
Collaborator

@pd-redis pd-redis Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this pattern. It seems like there are a lot of cases, where some margin around the divider can be useful. Maybe it is worth it to explore adding props to Divider component to do this with styles?

Copy link
Collaborator Author

@dantovska dantovska Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, sometimes we want space just before the divider, sometimes only after, sometimes there is space in some other component around it and it adds additional space. I agree that it is starting to look like a pattern but is either adding custom styling with margin everywhere, or the spacer IMO - adding to the divider will just make the component more complex.

valkirilov
valkirilov previously approved these changes Nov 4, 2025
View reviewed changes
@dantovska
adjust some spacings and alignment around the dividers in the lower s…
1e52b41 
…ection
@dantovska
increase footer button sizes
3ef2e68
@dantovska
replace the hard coded asterisk with required; add space between forms
38f1b91
@dantovska
replace the Arrow Left icon <- with Chevron icon <
8965d43
@dantovska
add the info icon
e22c169
@dantovska
attempt to fix the double scroll layout issue
d066e33
@dantovska
remove unused divider class
405b66b
@dantovska
fix margin for tls details
1d5f455
@dantovska
fix spacing around security items
558dc4f
@dantovska
adjust decompression and formatters tab spacing
30b8d09
@dantovska
adjust spacings and required fields in ssh and tls details
f2a8aec
@dantovska
adjust spacings in the edit db connectivity settings
b8df8c7
@dantovska
decrease spacer below private key / pass radio
81fb8c8
@dantovska
adjust spacings and dividers to reduce space and not cause extra scrolls
ee2bd6e
@dantovska
use text for the label to make the format match the designs
9c61a9d
@dantovska
decrease some spacings
a1f6f1b
@dantovska
remove the "should not exceed constraint"
31352be
@dantovska dantovska force-pushed the fe/feature/RI-7681-connection-settings branch from c07b272 to ff95d79 Compare November 4, 2025 13:07
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Code Coverage - Frontend unit tests

St.❔
 Category Percentage Covered / Total
🟢 Statements 82.53% 20295/24592
🟡 Branches 67.82% 8751/12904
🟡 Functions 77.04% 5430/7048
🟢 Lines 82.95% 19875/23960

Test suite run success

5229 tests passing in 681 suites.

Report generated by 🧪jest coverage report action from 9591d7a

ArtemHoruzhenko
ArtemHoruzhenko approved these changes Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dantovska dantovska merged commit f12d4a1 into main Nov 5, 2025
18 checks passed
@dantovska dantovska deleted the fe/feature/RI-7681-connection-settings branch November 5, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pd-redis pd-redis pd-redis left review comments

@valkirilov valkirilov valkirilov approved these changes

@ArtemHoruzhenko ArtemHoruzhenko ArtemHoruzhenko approved these changes

@KrumTy KrumTy Awaiting requested review from KrumTy KrumTy is a code owner

@pawelangelow pawelangelow Awaiting requested review from pawelangelow pawelangelow is a code owner

Assignees

@dantovska dantovska

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dantovska @valkirilov @ArtemHoruzhenko @pd-redis