WIP: JSON validation POC #47
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a validation schema for pyperf's output, this will allow us to automatically verify the results. Test - Doesn't matter what it is, so long as it is there Avg - Average runtime of the test, floating point number > 0 Unit - Unit of the average runtime, can be sec, ms, us, ns Co-developed-by: Cursor
This adds tests for the validation schema, so issues can be identified before PRs are merged Co-developed-by: Cursor
This adds a github action to verify that the validation unit tests in this repo pass. This will give us early alerts if a PR breaks the validation process. Co-developed-by: Cursor
This adds calls to test_tools-wrapper to convert the CSV results file to JSON and then read that JSON file to verify it matches the provided schema Co-developed-by: Cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes an attempt to use JSON schemas to validate proper results.
Before/After Comparison
Before
Results are either verified via regex or not verified at all
This is undesirable as regex is a bear to maintain
After
Results are verified using pydantic, which leverages JSON schemas.
Clerical Stuff
Mention the issue this PR works toward resolving. If the
PR completely solves the issue, use "This closes #x"
to close the issue out automatically.
Mention the JIRA ticket of the issue, this helps keep
everything together so we can find this PR easily.
Relates to JIRA: RPOPC-<TICKET_NUMBER>