Remove warnings from terminal when compiling the test runner. #91
Conversation
nicrowe00
force-pushed
the
warnings
branch
3 times, most recently
from
c51809d to
a5cb32c
Compare
|
CentOS 9 and 10 are unrelated to this PR. |
|
@nicrowe00 thanks for tacking this! Some of the changes you are making made me wonder if the analyzers you are fixing against are more strict than what I'm used to. I see there are some analyser references being made: dotnet-bunny/Turkey/Turkey.csproj Lines 17 to 19 in 116605a If we want to keep these analyzers but don't want to strictly apply every rule (for example requiring the |
nicrowe00
force-pushed
the
warnings
branch
6 times, most recently
from
7095b97 to
3fdf49d
Compare
|
Current CI failures are due to release-version-sane, most OS' don't have the latest .NET version yet. |
| { | ||
| return text.Substring(1, text.Length - 2); | ||
| } | ||
|
|
||
| return text; | ||
| } | ||
|
|
||
| #pragma warning disable CA1822 // Mark members as static | ||
| internal string GetLddVersion() |
There was a problem hiding this comment.
Other methods are now static, so I am okay with marking this as static too.
There was a problem hiding this comment.
Setting this to static causes an error when executing dotnet test -f net6.0 -c Release --verbosity detailed Turkey.Tests
Error: Turkey.Tests/PlatformIdTest.cs(34,30): error CS0176: Member 'PlatformId.GetLddVersion()' cannot be accessed with an instance reference; qualify it with a type name instead
A fix for the test runner that patches most of the warnings that are reported in the terminal when compiling the test runner. Some warnings were suppressed as it was too time-consuming or there were impacts to other parts of the test runner when they were fixed.
A fix for the test runner that patches most of the warnings that are reported in the terminal when compiling the test runner. Some warnings were suppressed as it was too time-consuming or there were impacts to other parts of the test runner when they were fixed.
Fixes #83