Skip to content

Conversation

mdusher
Copy link

@mdusher mdusher commented Aug 25, 2024

Hello,

I added a colour scheme switcher to the Preferences page and added a second colour scheme.

I've called the second colour scheme "Black White" because the light theme is mostly Black text on a white background and the dark theme is mostly white text on a black background (creative, I know).

I added it mostly because it suits my own preference but thought I'd do a pull request in case you'd like to include it (this is my first time touching any sort of Android dev so happy to modify anything if you have a preferred way of doing things).

image
image

@mdusher mdusher force-pushed the alt-colour-scheme branch from 692ae87 to e67efd2 Compare August 26, 2024 05:52
@Lokito23
Copy link

On the mentioned issue, I managed to add Material You support to this PR, though I'm unsure if you would like if I commited this functionality into the PR.

It still requires a method to check if the Android version is too old, in order to disable the option, but besides that it seems like it works.

@mdusher mdusher force-pushed the alt-colour-scheme branch from 68b9ede to 6f0e049 Compare April 18, 2025 12:02
@mdusher mdusher force-pushed the alt-colour-scheme branch from adc9f9d to 04512d6 Compare April 18, 2025 12:20
@mdusher
Copy link
Author

mdusher commented Apr 18, 2025

I've pulled in the 'develop' branch and updated the PR to match the more recent changes.
image

@Lokito23 I'm happy to pull your changes into this PR if you have them available somewhere

@mdusher
Copy link
Author

mdusher commented Apr 18, 2025

Adding that this would likely address #120

@Lokito23
Copy link

Lokito23 commented Apr 18, 2025

Couldn't manage to rebase, so I just redid my changes, currently trying if it still works.

My guess is that to contribute to the PR, I have to open a PR on the PR, correct me if I'm wrong.

Edit: I'll do it that way anyways, also it does work.

@mdusher mdusher changed the title Add colour scheme switch and black & white theme Add colour scheme switcher with Black & White and Material You theme Apr 19, 2025
@mdusher
Copy link
Author

mdusher commented Apr 19, 2025

Thanks, I gave your changes a quick test and I've merged your pull request into my branch (and updated the title of this PR to match)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants