-
-
Notifications
You must be signed in to change notification settings - Fork 28
App strings reworked #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
App strings reworked #136
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #136 +/- ##
==========================================
Coverage 20.86% 20.86%
Complexity 351 351
==========================================
Files 118 118
Lines 5109 5109
Branches 603 603
==========================================
Hits 1066 1066
Misses 3980 3980
Partials 63 63 Continue to review full report at Codecov.
|
@@ -1,7 +1,7 @@ | |||
<resources> | |||
<string name="app_name" translatable="false">readropsdb</string> | |||
<string name="app_name" translatable="false">ReadropsDB</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assumption on my part
<string name="delete_feed">Delete feed ?</string> | ||
<string name="load">Load</string> | ||
<string name="updating_feed">Updating feed : %1$s</string> | ||
<string name="updating_feed">Updating feed, %1$s…</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="updating_feed">Updating feed, %1$s…</string> | |
<string name="updating_feed">Updating the %1$s feed…</string> |
On the assumption it is the name of the feed
<string name="feed_insertion_wrong_format">Wrong format for feed %1$s</string> | ||
<string name="feed_insertion_unknown_error">Unknown error for feed %1$s</string> | ||
<string name="feed_insertion_successfull">Added the %1$s feed</string> | ||
<string name="feed_insertion_network_failed">Could not access the %1$s feed due to a network failure</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is network failure anything outside of not connected to the Internet?
<string name="account_url">Account URL</string> | ||
<string name="account_name">Account name</string> | ||
<string name="login">Login</string> | ||
<string name="login">Username</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure here, but this would avoid errors in translation
<string name="add_account">Add account</string> | ||
<string name="no_feed">No feed</string> | ||
<string name="choose_account">Choose an account</string> | ||
<string name="choose_account">Choose setup</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the setup screen, where IMO "account" again doesn't really do anything
<string name="download_image_permission">To download the image, storage permission is needed</string> | ||
<string name="auto_synchro">Automatic synchronisation</string> | ||
<string name="download_image_permission">Grant storage access to download the image</string> | ||
<string name="auto_synchro">Syncing</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="auto_synchro">Syncing</string> | |
<string name="auto_synchro">Auto-syncing</string> |
Somehow it isn't auto if set to "manual", but consistent with "turn on ___" below.
Maybe go with "Syncing" for both?
<string name="auto_synchro">Automatic synchronisation</string> | ||
<string name="download_image_permission">Grant storage access to download the image</string> | ||
<string name="auto_synchro">Syncing</string> | ||
<string name="manual">Manual</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="manual">Manual</string> | |
<string name="manual">Only manual</string> |
Better than "No", works with "Auto"?
With the upcoming 2.0 release, translations strings changed a lot. Would you still like to continue working on this? |
@Shinokuni Do you want me to try my hand at sorting everything after "CHANGELOG" too? Sorted the conflicts for now. There are some open comments with questions. |
No description provided.