Skip to content

Conversation

comradekingu
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #136 (1915cf5) into develop (6f7e2b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #136   +/-   ##
==========================================
  Coverage      20.86%   20.86%           
  Complexity       351      351           
==========================================
  Files            118      118           
  Lines           5109     5109           
  Branches         603      603           
==========================================
  Hits            1066     1066           
  Misses          3980     3980           
  Partials          63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7e2b7...1915cf5. Read the comment docs.

@@ -1,7 +1,7 @@
<resources>
<string name="app_name" translatable="false">readropsdb</string>
<string name="app_name" translatable="false">ReadropsDB</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumption on my part

<string name="delete_feed">Delete feed ?</string>
<string name="load">Load</string>
<string name="updating_feed">Updating feed : %1$s</string>
<string name="updating_feed">Updating feed, %1$s</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="updating_feed">Updating feed, %1$s…</string>
<string name="updating_feed">Updating the %1$s feed…</string>

On the assumption it is the name of the feed

<string name="feed_insertion_wrong_format">Wrong format for feed %1$s</string>
<string name="feed_insertion_unknown_error">Unknown error for feed %1$s</string>
<string name="feed_insertion_successfull">Added the %1$s feed</string>
<string name="feed_insertion_network_failed">Could not access the %1$s feed due to a network failure</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is network failure anything outside of not connected to the Internet?

<string name="account_url">Account URL</string>
<string name="account_name">Account name</string>
<string name="login">Login</string>
<string name="login">Username</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure here, but this would avoid errors in translation

<string name="add_account">Add account</string>
<string name="no_feed">No feed</string>
<string name="choose_account">Choose an account</string>
<string name="choose_account">Choose setup</string>
Copy link
Contributor Author

@comradekingu comradekingu Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the setup screen, where IMO "account" again doesn't really do anything

<string name="download_image_permission">To download the image, storage permission is needed</string>
<string name="auto_synchro">Automatic synchronisation</string>
<string name="download_image_permission">Grant storage access to download the image</string>
<string name="auto_synchro">Syncing</string>
Copy link
Contributor Author

@comradekingu comradekingu Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="auto_synchro">Syncing</string>
<string name="auto_synchro">Auto-syncing</string>

Somehow it isn't auto if set to "manual", but consistent with "turn on ___" below.
Maybe go with "Syncing" for both?

<string name="auto_synchro">Automatic synchronisation</string>
<string name="download_image_permission">Grant storage access to download the image</string>
<string name="auto_synchro">Syncing</string>
<string name="manual">Manual</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="manual">Manual</string>
<string name="manual">Only manual</string>

Better than "No", works with "Auto"?

@Shinokuni
Copy link
Member

With the upcoming 2.0 release, translations strings changed a lot. Would you still like to continue working on this?

@comradekingu
Copy link
Contributor Author

@Shinokuni
Moreso, I would like it to get merged ;)

Do you want me to try my hand at sorting everything after "CHANGELOG" too?
Can do that in a separate PR to get this moving.

Sorted the conflicts for now.

There are some open comments with questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants