fix: Prevent double root path when reporting metrics from FastAPI #1275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FastAPI, when the
root_pathis configured, it's included both in thebase_urland in thepath:To avoid reporting
https://acme.com/api/v1/api/v1/my_endpoint, this PR adds trimming of the redundantroot_path.🧰 Changes
root_pathpathindeed starts with it, trim it from thepath.🧬 QA & Testing
Any FastAPI setup with the
root_pathconfigured.