Skip to content
This repository was archived by the owner on May 7, 2025. It is now read-only.

Fixes issue with text clipping from page turning. Fixes #283 #288

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixes issue with text clipping from page turning. Fixes #283 #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/views/reflowable_view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ var ReflowableView = function(options, reader){

function onPaginationChanged_(initiator, paginationRequest_spineItem, paginationRequest_elementId) {

_paginationInfo.pageOffset = (_paginationInfo.columnWidth + _paginationInfo.columnGap) * _paginationInfo.visibleColumnCount * _paginationInfo.currentSpreadIndex;
_paginationInfo.pageOffset = _paginationInfo.pageOffsetSize * _paginationInfo.currentSpreadIndex;

redraw();

Expand Down Expand Up @@ -693,7 +693,7 @@ var ReflowableView = function(options, reader){
_$htmlBody.css('padding', 0);

_paginationInfo.rightToLeft = _spine.isRightToLeft();

_paginationInfo.pageOffsetSize = _htmlBodyIsVerticalWritingMode ? _lastViewPortSize.height : (_lastViewPortSize.width + _paginationInfo.columnGap);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, _htmlBodyIsVerticalWritingMode ? _lastViewPortSize.height : (_lastViewPortSize.width + _paginationInfo.columnGap) replaces (_paginationInfo.columnWidth + _paginationInfo.columnGap) * _paginationInfo.visibleColumnCount (see onPaginationChanged_() _paginationInfo.pageOffset = _paginationInfo.pageOffsetSize * _paginationInfo.currentSpreadIndex; in the source above) where _paginationInfo.columnWidth was Math.round(((_htmlBodyIsVerticalWritingMode ? _lastViewPortSize.height : _lastViewPortSize.width) - _paginationInfo.columnGap * (_paginationInfo.visibleColumnCount - 1)) / _paginationInfo.visibleColumnCount); ... I have to look at the arithmetics to make sure this does not affect vertical writing mode, or some other column-gap related edge-case computations :)

_paginationInfo.columnWidth = Math.round(((_htmlBodyIsVerticalWritingMode ? _lastViewPortSize.height : _lastViewPortSize.width) - _paginationInfo.columnGap * (_paginationInfo.visibleColumnCount - 1)) / _paginationInfo.visibleColumnCount);

var useColumnCountNotWidth = _paginationInfo.visibleColumnCount > 1; // column-count == 1 does not work in Chrome, and is not needed anyway (HTML width is full viewport width, no Firefox video flickering)
Expand Down